fix: remove the flag disabling bfcache (#11047)

puppeteer · Sep 28, 2023 · b0d7375 · b0d7375
1 parent 30bd030
commit b0d7375
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/packages/puppeteer-core/src/node/ChromeLauncher.ts b/packages/puppeteer-core/src/node/ChromeLauncher.ts
@@ -177,7 +177,6 @@ export class ChromeLauncher extends ProductLauncher {
 
     if (!USE_TAB_TARGET) {
       disabledFeatures.push('Prerender2');
-      disabledFeatures.push('BackForwardCache');
     }
 
     const chromeArguments = [

diff --git a/test/TestExpectations.json b/test/TestExpectations.json
@@ -1019,6 +1019,12 @@
     "parameters": ["webDriverBiDi"],
     "expectations": ["PASS"]
   },
+  {
+    "testIdPattern": "[page.spec] Page Page.select should not throw when select causes navigation",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["webDriverBiDi"],
+    "expectations": ["PASS"]
+  },
   {
     "testIdPattern": "[page.spec] Page Page.select should respect event bubbling",
     "platforms": ["darwin", "linux", "win32"],
@@ -3173,12 +3179,6 @@
     "parameters": ["cdp", "firefox"],
     "expectations": ["FAIL"]
   },
-  {
-    "testIdPattern": "[page.spec] Page Page.select should not throw when select causes navigation",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["webDriverBiDi"],
-    "expectations": ["PASS"]
-  },
   {
     "testIdPattern": "[page.spec] Page Page.select should work when re-defining top-level Event class",
     "platforms": ["darwin", "linux", "win32"],
@@ -3862,11 +3862,5 @@
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["cdp", "chrome", "headless"],
     "expectations": ["FAIL", "PASS"]
-  },
-  {
-    "testIdPattern": "[coverage.spec] Coverage specs JSCoverage resetOnNavigation should report scripts across navigations when disabled",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["cdp", "chrome", "new-headless", "tabTarget"],
-    "expectations": ["FAIL"]
   }
 ]
diff --git a/test/src/coverage.spec.ts b/test/src/coverage.spec.ts
@@ -165,6 +165,8 @@ describe('Coverage specs', function () {
 
         await page.coverage.startJSCoverage({resetOnNavigation: false});
         await page.goto(server.PREFIX + '/jscoverage/multiple.html');
+        // TODO: navigating too fast might loose JS coverage data in the browser.
+        await page.waitForNetworkIdle();
         await page.goto(server.EMPTY_PAGE);
         const coverage = await page.coverage.stopJSCoverage();
         expect(coverage).toHaveLength(2);