chore: addScriptToEvaluateOnNewDocument on page

puppeteer · Aug 23, 2022 · c4d9525 · c4d9525
1 parent 341b669
commit c4d9525
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/src/common/FrameManager.ts b/src/common/FrameManager.ts
@@ -23,7 +23,7 @@ import {
 import {isErrorLike} from '../util/ErrorLike.js';
 import {CDPSession} from './Connection.js';
 import {EventEmitter} from './EventEmitter.js';
-import {EVALUATION_SCRIPT_URL, ExecutionContext} from './ExecutionContext.js';
+import {ExecutionContext} from './ExecutionContext.js';
 import {Frame} from './Frame.js';
 import {IsolatedWorld, MAIN_WORLD, PUPPETEER_WORLD} from './IsolatedWorld.js';
 import {NetworkManager} from './NetworkManager.js';
@@ -32,7 +32,7 @@ import {Target} from './Target.js';
 import {TimeoutSettings} from './TimeoutSettings.js';
 import {debugError} from './util.js';
 
-const UTILITY_WORLD_NAME = '__puppeteer_utility_world__';
+export const UTILITY_WORLD_NAME = '__puppeteer_utility_world__';
 
 /**
  * We use symbols to prevent external parties listening to these events.
@@ -389,11 +389,6 @@ export class FrameManager extends EventEmitter {
       return;
     }
 
-    await session.send('Page.addScriptToEvaluateOnNewDocument', {
-      source: `//# sourceURL=${EVALUATION_SCRIPT_URL}`,
-      worldName: name,
-    });
-
     await Promise.all(
       this.frames()
         .filter(frame => {

diff --git a/src/common/Page.ts b/src/common/Page.ts
@@ -28,7 +28,11 @@ import {ElementHandle} from './ElementHandle.js';
 import {EmulationManager} from './EmulationManager.js';
 import {EventEmitter, Handler} from './EventEmitter.js';
 import {FileChooser} from './FileChooser.js';
-import {FrameManager, FrameManagerEmittedEvents} from './FrameManager.js';
+import {
+  FrameManager,
+  FrameManagerEmittedEvents,
+  UTILITY_WORLD_NAME,
+} from './FrameManager.js';
 import {Frame} from './Frame.js';
 import {HTTPRequest} from './HTTPRequest.js';
 import {HTTPResponse} from './HTTPResponse.js';
@@ -73,6 +77,7 @@ import {
   DeferredPromise,
 } from '../util/DeferredPromise.js';
 import {WebWorker} from './WebWorker.js';
+import {EVALUATION_SCRIPT_URL} from './ExecutionContext.js';
 
 /**
  * @public
@@ -641,6 +646,10 @@ export class Page extends EventEmitter {
       this.#frameManager.initialize(this.#target._targetId),
       this.#client.send('Performance.enable'),
       this.#client.send('Log.enable'),
+      this.#client.send('Page.addScriptToEvaluateOnNewDocument', {
+        source: `//# sourceURL=${EVALUATION_SCRIPT_URL}`,
+        worldName: UTILITY_WORLD_NAME,
+      }),
     ]);
   }