fix: remove the flag disabling bfcache

puppeteer · Sep 28, 2023 · cb299a6 · cb299a6
1 parent 30bd030
commit cb299a6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/packages/puppeteer-core/src/node/ChromeLauncher.ts b/packages/puppeteer-core/src/node/ChromeLauncher.ts
@@ -177,7 +177,6 @@ export class ChromeLauncher extends ProductLauncher {
 
     if (!USE_TAB_TARGET) {
       disabledFeatures.push('Prerender2');
-      disabledFeatures.push('BackForwardCache');
     }
 
     const chromeArguments = [

diff --git a/test/TestExpectations.json b/test/TestExpectations.json
@@ -3862,11 +3862,5 @@
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["cdp", "chrome", "headless"],
     "expectations": ["FAIL", "PASS"]
-  },
-  {
-    "testIdPattern": "[coverage.spec] Coverage specs JSCoverage resetOnNavigation should report scripts across navigations when disabled",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["cdp", "chrome", "new-headless", "tabTarget"],
-    "expectations": ["FAIL"]
   }
 ]
diff --git a/test/src/coverage.spec.ts b/test/src/coverage.spec.ts
@@ -164,7 +164,9 @@ describe('Coverage specs', function () {
         const {page, server} = await getTestState();
 
         await page.coverage.startJSCoverage({resetOnNavigation: false});
-        await page.goto(server.PREFIX + '/jscoverage/multiple.html');
+        await page.goto(server.PREFIX + '/jscoverage/multiple.html', {
+          waitUntil: 'networkidle2',
+        });
         await page.goto(server.EMPTY_PAGE);
         const coverage = await page.coverage.stopJSCoverage();
         expect(coverage).toHaveLength(2);