fix(typescript): allow defaultViewport to be 'null' (#6942)

Fixes: #6885 Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
puppeteer · Mar 24, 2021 · e31e68d · e31e68d
1 parent c62b02f
commit e31e68d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/common/Browser.ts b/src/common/Browser.ts
@@ -184,7 +184,7 @@ export class Browser extends EventEmitter {
     connection: Connection,
     contextIds: string[],
     ignoreHTTPSErrors: boolean,
-    defaultViewport?: Viewport,
+    defaultViewport?: Viewport | null,
     process?: ChildProcess,
     closeCallback?: BrowserCloseCallback
   ): Promise<Browser> {
@@ -200,7 +200,7 @@ export class Browser extends EventEmitter {
     return browser;
   }
   private _ignoreHTTPSErrors: boolean;
-  private _defaultViewport?: Viewport;
+  private _defaultViewport?: Viewport | null;
   private _process?: ChildProcess;
   private _connection: Connection;
   private _closeCallback: BrowserCloseCallback;
@@ -219,7 +219,7 @@ export class Browser extends EventEmitter {
     connection: Connection,
     contextIds: string[],
     ignoreHTTPSErrors: boolean,
-    defaultViewport?: Viewport,
+    defaultViewport?: Viewport | null,
     process?: ChildProcess,
     closeCallback?: BrowserCloseCallback
   ) {

diff --git a/src/common/BrowserConnector.ts b/src/common/BrowserConnector.ts
@@ -37,7 +37,7 @@ export interface BrowserConnectOptions {
   /**
    * Sets the viewport for each page.
    */
-  defaultViewport?: Viewport;
+  defaultViewport?: Viewport | null;
   /**
    * Slows down Puppeteer operations by the specified amount of milliseconds to
    * aid debugging.