feat: add durableStorage to allowed permissions (#5295)

puppeteer · Sep 16, 2021 · eda5171 · eda5171
1 parent 54c4318
commit eda5171
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/docs/api.md b/docs/api.md
@@ -1094,6 +1094,7 @@ Creates a new page in the browser context.
   - `'clipboard-read'`
   - `'clipboard-write'`
   - `'payment-handler'`
+  - `'persistent-storage'`
 - returns: <[Promise]>
 
 ```js

diff --git a/src/common/Browser.ts b/src/common/Browser.ts
@@ -56,6 +56,7 @@ const WEB_PERMISSION_TO_PROTOCOL_PERMISSION = new Map<
   ['clipboard-read', 'clipboardReadWrite'],
   ['clipboard-write', 'clipboardReadWrite'],
   ['payment-handler', 'paymentHandler'],
+  ['persistent-storage', 'durableStorage'],
   ['idle-detection', 'idleDetection'],
   // chrome-specific permissions we have.
   ['midi-sysex', 'midiSysex'],
@@ -79,6 +80,7 @@ export type Permission =
   | 'clipboard-read'
   | 'clipboard-write'
   | 'payment-handler'
+  | 'persistent-storage'
   | 'idle-detection'
   | 'midi-sysex';
 

diff --git a/test/page.spec.ts b/test/page.spec.ts
@@ -339,6 +339,18 @@ describe('Page', function () {
         await otherContext.close();
       }
     );
+    itFailsFirefox('should grant persistent-storage', async () => {
+      const { page, server, context } = getTestState();
+
+      await page.goto(server.EMPTY_PAGE);
+      expect(await getPermission(page, 'persistent-storage')).not.toBe(
+        'granted'
+      );
+      await context.overridePermissions(server.EMPTY_PAGE, [
+        'persistent-storage',
+      ]);
+      expect(await getPermission(page, 'persistent-storage')).toBe('granted');
+    });
   });
 
   describe('Page.setGeolocation', function () {