Skip to content

Commit

Permalink
test: run Frame.evaluate tests on Firefox (#8296)
Browse files Browse the repository at this point in the history
  • Loading branch information
kblok committed May 2, 2022
1 parent 94cb08c commit f39eb70
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/common/Page.ts
Expand Up @@ -2824,7 +2824,7 @@ export class Page extends EventEmitter {
}

/**
* Generatees a PDF of the page with the `print` CSS media type.
* Generates a PDF of the page with the `print` CSS media type.
* @remarks
*
* NOTE: PDF generation is only supported in Chrome headless mode.
Expand Down
4 changes: 2 additions & 2 deletions test/evaluation.spec.ts
Expand Up @@ -436,7 +436,7 @@ describe('Evaluation specs', function () {
});

describe('Frame.evaluate', function () {
itFailsFirefox('should have different execution contexts', async () => {
it('should have different execution contexts', async () => {
const { page, server } = getTestState();

await page.goto(server.EMPTY_PAGE);
Expand All @@ -447,7 +447,7 @@ describe('Evaluation specs', function () {
expect(await page.frames()[0].evaluate(() => globalThis.FOO)).toBe('foo');
expect(await page.frames()[1].evaluate(() => globalThis.FOO)).toBe('bar');
});
itFailsFirefox('should have correct execution contexts', async () => {
it('should have correct execution contexts', async () => {
const { page, server } = getTestState();

await page.goto(server.PREFIX + '/frames/one-frame.html');
Expand Down

0 comments on commit f39eb70

Please sign in to comment.