chore: extract Request and Response into its own module

puppeteer · May 13, 2020 · f7691e7 · f7691e7
1 parent 5f42547
commit f7691e7
Show file tree

Hide file tree

Showing 6 changed files with 470 additions and 427 deletions.
diff --git a/src/FrameManager.ts b/src/FrameManager.ts
@@ -20,12 +20,13 @@ import { Events } from './Events';
 import { ExecutionContext, EVALUATION_SCRIPT_URL } from './ExecutionContext';
 import { LifecycleWatcher, PuppeteerLifeCycleEvent } from './LifecycleWatcher';
 import { DOMWorld, WaitForSelectorOptions } from './DOMWorld';
-import { NetworkManager, Response } from './NetworkManager';
+import { NetworkManager } from './NetworkManager';
 import { TimeoutSettings } from './TimeoutSettings';
 import { CDPSession } from './Connection';
 import { JSHandle, ElementHandle } from './JSHandle';
 import { MouseButtonInput } from './Input';
 import { Page } from './Page';
+import { Response } from './Response';
 
 const UTILITY_WORLD_NAME = '__puppeteer_utility_world__';
 

diff --git a/src/LifecycleWatcher.ts b/src/LifecycleWatcher.ts
@@ -18,7 +18,8 @@ import { helper, assert, PuppeteerEventListener } from './helper';
 import { Events } from './Events';
 import { TimeoutError } from './Errors';
 import { FrameManager, Frame } from './FrameManager';
-import { Request, Response } from './NetworkManager';
+import { Request } from './Request';
+import { Response } from './Response';
 
 export type PuppeteerLifeCycleEvent =
   | 'load'