Skip to content

Commit

Permalink
Ensure all tests honour the BINARY envvar.
Browse files Browse the repository at this point in the history
Without this patch, two tests ignore the BINARY envvar, and fail unless the
chromium executable path is defined via PUPPETEER_EXECUTABLE_PATH, which should
not be considered.
  • Loading branch information
NightTsarina committed Mar 2, 2022
1 parent e11fe71 commit fc2fb14
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/launcher.spec.ts
Expand Up @@ -708,9 +708,9 @@ describe('Launcher specs', function () {
itFailsFirefox(
'should be able to connect to the same page simultaneously',
async () => {
const { puppeteer } = getTestState();
const { puppeteer, defaultBrowserOptions } = getTestState();

const browserOne = await puppeteer.launch();
const browserOne = await puppeteer.launch(defaultBrowserOptions);
const browserTwo = await puppeteer.connect({
browserWSEndpoint: browserOne.wsEndpoint(),
});
Expand All @@ -726,8 +726,8 @@ describe('Launcher specs', function () {
}
);
it('should be able to reconnect', async () => {
const { puppeteer, server } = getTestState();
const browserOne = await puppeteer.launch();
const { puppeteer, server, defaultBrowserOptions } = getTestState();
const browserOne = await puppeteer.launch(defaultBrowserOptions);
const browserWSEndpoint = browserOne.wsEndpoint();
const pageOne = await browserOne.newPage();
await pageOne.goto(server.EMPTY_PAGE);
Expand Down

0 comments on commit fc2fb14

Please sign in to comment.