Comparing changes
Open a pull request
Commits on Jul 2, 2020
Commits on Jul 3, 2020
-
fix: make Node.js environment detection robust w.r.t. JSDOM (#6148)
Previously Node.js was detected by the lack of `global.document` which doesn’t work in case JSDOM is being used in Node.js. Instead, we now detect `process.versions.node`, like here: https://github.com/MatthewSH/is-node/commit/426943ae936536f9c2fd10fd58a9a46b59470097#diff-168726dbe96b3ce427e7fedce31bb0bc. Fixes #6147.
-
-
docs: migrating Page.ts to TSDoc (#6152)
* docs: a small batch of page TSdoc migration Co-authored-by: Changhao Han <changhaohan@chromium.org>
-
chore(docs): document HTTPRequest with TSDoc (#6146)
* chore(docs): document HTTPRequest with TSDoc * doclint * example
-
feat(types): add types for
page.$$eval(#6139)* feat(types): add types for `page.$$eval` * Add new-docs for $$eval * fix example * linting
Commits on Jul 6, 2020
-
-
chore(docs): migrate & document all Page events (#6154)
* chore(docs): migrate & document all Page events Rather than a generic `Events.ts` file we can instead document events as an enum within each individual class. It's easier to document and work with, and it's clearer where events originate from.
-
-
chore(docs): fix DOMWorld doc warnings (#6166)
I noticed that DOMWorld was spitting a lot of warnings out when we generated the docs. It was mostly easy tidy-ups and removing old JSDoc comments and now the warnings are gone :)
Commits on Jul 7, 2020
-
-
-
chore: migrate NetworkManager events (#6174)
This is part of the effort to remove `Events.ts` in favour of defining events next to the class that emits them. In this case these events are internal, so there's no docs changes, but it's still worth doing such that we can remove the Events.ts file in the long term once all the different events are migrated.
Commits on Jul 8, 2020
-
chore(docs): fix incorrect
@returnson getter (#6175)On a getter function you don't use `@returns` (as that's just for methods). Instead we can just add to the general remarks to explain what the property is providing.
-
-
-
chore: forbid importing src/common/Events.ts (#6183)
This file is now deprecated and only used by the coverage tool and DocLint - these tools will be updated to not rely on it in the future. We now have events defined per class - e.g. all the events that `Page` can emit are defined in the `PageEmittedEvents` enum, and similar. We have to keep `Events.ts` around for the aforementioned tools, but don't want its usage creeping back into our source code.
Commits on Jul 9, 2020
-
chore: remove
installAsyncStackHookshelper (#6186)* chore: remove `installAsyncStackHooks` helper This code was written when browsers/Node didn't support errors in async functions very well. They now do a much better job of this, so we can lose the additonal complexity from our codebase and leave it to the host environment :) * lazy launcher is private * remove async stack test
-
chore(docs): document Frame class (#6188)
* chore: document Frame class
-
chore(docs): tidy Puppeteer class docs (#6181)
* Mark properties as `private` or `@internal` so they don't get documented. * Fix the `@returns` on a getter which gets ignored.
Commits on Jul 10, 2020
-
chore: remove src/api.ts (#6191)
Now the async hooks helper is gone api.ts was only used by the coverage tools and by doclint. DocLint is nearing the end of its lifespan with the TSDoc work, so I focused on how best to define a list of modules for the coverage tooling. They define an object of classes, and the path to that module. They need the full path because we also check if the module exports any events that need to be emitted - the coverage tool asserts that the emitting of those events is also tested. It's not _great_ that DocLint relies on a constant defined in the coverage utils, but it should only be this way for a short period of time and no one is actively working on DocLint (bar the effort to remove it) so I don't think this is worth worrying about. This change also broke the DocLint tests; based on the fact that DocLint is on its way out it doesn't feel worth fixing the tests, so this commit also removes them.
-
chore: use devtools-protocol package (#6172)
* chore: Use devtools-protocol package Rather than maintain our own protocol we can instead use the devtools-protocol package and pin it to the version of Chromium that Puppeteer is shipping with. The only changes are naming changes between the bespoke protocol that Puppeteer created and the devtools-protocol one.
-
-
feat(chromium): roll Chromium to r768783 (#6201)
* feat(chromium): roll Chromium to r768783 * fix: update unit test for crrev:2135046 * chore: update devtools-protocol revision Co-authored-by: Changhao Han <changhaohan@chromium.org>
Commits on Jul 13, 2020
-
chore: mark version v5.1.0 (#6206)
Co-authored-by: Changhao Han <changhaohan@chromium.org>
There are no files selected for viewing