feat: enable tab targets #11099
Merged
feat: enable tab targets #11099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/tab-target
branch
2 times, most recently
from
88e118b
to
7edc3d4
Compare
Lightning00Blade
approved these changes
Oct 9, 2023
[Tab target is a new type of target in CDP](https://docs.google.com/document/d/14aeiC_zga2SS0OXJd6eIFj8N0o5LGwUpuqa4L8NKoR4/edit) that reflects the architectural changes in Chromium that were needed for features such as bfcache, portal and prerendering. Previously, the `page` targets were the top-level targets representing the entire tab. If you navigate to a new URL, the page target would remain the same. With the introduction of the `tab` target, it's not possible to have multiple page targets active within one tab. For example, one page would be the currently shown page and the other one would be a [prerendered](https://github.com/WICG/nav-speculation/) page. When the user navigates to the prerendered page, the secondary page becomes the primary and the primary page target gets destroyed (the process is called activation). This change enables tab targets and allows testing Chrome features related to prerendering. Emulation and network manager domains should work with the prerendered targets. Some features like JS/CSS coverage might not work over activation so you would need to disable activation to test those. Use command line flags to disable prerendering in Chrome if you encounter issues. For example, ``` --disable-features=Prerender2 ```
OrKoN
force-pushed
the
orkon/tab-target
branch
from
f138e21
to
1e3780d
Compare
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tab target is a new type of target in CDP that reflects the architectural changes in Chromium that were needed for features such as bfcache, portals and prerendering.
Previously, the
pagetargets were the top-level targets representing the entire tab. If you navigate to a new URL, the page target would remain the same. With the introduction of thetabtarget, it's not possible to have multiple page targets active within one tab. For example, one page would be the currently shown page and the other one would be a prerendered page. When the user navigates to the prerendered page, the secondary page becomes the primary and the primary page target gets destroyed (the process is called activation).This change enables tab targets and allows testing Chrome features related to prerendering. Emulation and network manager domains should work with the prerendered targets. Some features like JS/CSS coverage might not work during the activation so you would need to disable prerendering to test those.
Use command line flags to disable prerendering in Chrome if you encounter issues. For example,