Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable tab targets #11099

Merged
merged 3 commits into from
Oct 9, 2023
Merged

feat: enable tab targets #11099

merged 3 commits into from
Oct 9, 2023

Commits on Oct 9, 2023

  1. feat: enable tab targets 

    [Tab target is a new type of target in CDP](https://docs.google.com/document/d/14aeiC_zga2SS0OXJd6eIFj8N0o5LGwUpuqa4L8NKoR4/edit) that reflects the architectural changes in Chromium that were needed for features such as bfcache, portal and prerendering.

Previously, the `page` targets were the top-level targets representing the entire tab. If you navigate to a new URL, the page target would remain the same. With the introduction of the `tab` target, it's not possible to have multiple page targets active within one tab. For example, one page would be the currently shown page and the other one would be a [prerendered](https://github.com/WICG/nav-speculation/) page. When the user navigates to the prerendered page, the secondary page becomes the primary and the primary page target gets destroyed (the process is called activation).

This change enables tab targets and allows testing Chrome features related to prerendering.
Emulation and network manager domains should work with the prerendered targets. Some features
like JS/CSS coverage might not work over activation so you would need to disable activation to test those.

Use command line flags to disable prerendering in Chrome if you encounter issues. For example,
```
--disable-features=Prerender2
```
    @OrKoN
    OrKoN committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e6287c3 View commit details
    Browse the repository at this point in the history

  2. chore: bump firefox test version

    @OrKoN
    OrKoN committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1303d86 View commit details
    Browse the repository at this point in the history

  3. refactor: move filter definition

    @OrKoN
    OrKoN committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1e3780d View commit details
    Browse the repository at this point in the history