feat: merge user-provided --{disable,enable}-features in args

[thiagowfx]

Currently user-provided features are completely ignored in args, being overridden with default ones.

Bug: #11072

[OrKoN]

Currently user-provided features are completely ignored in args, being overridden with default ones.

Is it the case? I would expect that user-provided args override the default ones.

[thiagowfx]

Is it the case? I would expect that user-provided args override the default ones.

Yes. If you want to test it out locally, run this script:

#!/usr/bin/env node
import puppeteer from 'puppeteer';

(async () => {
  const browser = await puppeteer.launch({
    devtools: true,
    headless: false,
    args: ['--enable-features=WebBluetoothNewPermissionsBackend'],
  });
  const mainPage = await browser.newPage();
  await mainPage.goto(
    'http://googlechrome.github.io/samples/web-bluetooth/get-devices-async-await.html'
  );
  await mainPage.waitForNetworkIdle();
  await mainPage.waitForDevicePrompt();
})();

Then observe that a log message will appear in the page that says getDevices is not a function.
When the feature is enabled, this message does not appear.

[Lightning00Blade]

Suggested change

return opts.length === 0 ? [] : opts.join(',').split(',');

[thiagowfx]

The first suggestion was actually wrong. opts was created as an intermediate value. I was having compilation issues otherwise

[thiagowfx]

Done