-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Page.waitForDevicePrompt
crash
#11153
Conversation
I'm not sure if this fix is correct though. @mzgoddard @outofambit thoughts? I verified the crash doesn't happen anymore:
|
bf69009
to
284e4c3
Compare
Note that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Can we find a way to test it e2e on GitHub actions?
I confirm the unit tests did not change. I'll see if there's a way to E2E. |
284e4c3
to
2c2ef81
Compare
2c2ef81
to
5733a56
Compare
Tentative E2E: #11159 |
5733a56
to
257d5d4
Compare
Only call
deviceRequestPromptManager()
if the parent frame is not null.Bug: #11072
Follow-up-of: #9299