fix: close WebDriver BiDi session on disconnect #11470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
requested review from
Lightning00Blade and
OrKoN
and removed request for
Lightning00Blade
OrKoN
requested changes
Nov 30, 2023
Technically it is not breaking, as behavior has not changed and it should not change any existing workflows, but the API has changed. |
I can switch description to non-breaking, WDYT? |
sadym-chromium
force-pushed
the
sadym/disconnect
branch
from
b54333f
to
78db994
Compare
|
Converting to draft, as some tests are failing |
|
There are two concerns: 1) every breaking change results in a major puppeteer version which we don't want to bump so often 2) at the same time it does not look like it deserves a major version since there is no breaking behavior. |
OrKoN
reviewed
Nov 30, 2023
OrKoN
changed the title
OrKoN
changed the title
|
Let's go with |
OrKoN
approved these changes
Nov 30, 2023
added 6 commits
November 30, 2023 15:18
`browser.disconnect` returns `Promise<void>` instead of `void`. This is required ti be able to properly close BiDi session before disconnecting.
This reverts commit b54333f.
This reverts commit a7b3995db4c3f7d973be024eb6799d276944008f.
sadym-chromium
force-pushed
the
sadym/disconnect
branch
from
c356d29
to
abd7b87
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browser.disconnectreturnsPromise<void>instead ofvoid. This is required to be able to properly close BiDi session before disconnecting.browser.disconnectsendssession.endbefore disconnecting.Preparation for supporting
puppeteer.connectby Firefox.