Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close WebDriver BiDi session on disconnect #11470

Merged
merged 6 commits into from
Nov 30, 2023
Merged

fix: close WebDriver BiDi session on disconnect #11470

merged 6 commits into from
Nov 30, 2023

Commits on Nov 30, 2023

  1. feat!: close BiDi session properly 

    `browser.disconnect` returns `Promise<void>` instead of `void`. This is required ti be able to properly close BiDi session before disconnecting.
    @sadym-chromium
    Maksim Sadym authored and sadym-chromium committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    67168e5 View commit details
    Browse the repository at this point in the history

  2. Revert "feat!: close BiDi session properly" 

    This reverts commit b54333f.
    @sadym-chromium
    Maksim Sadym authored and sadym-chromium committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e22c42d View commit details
    Browse the repository at this point in the history

  3. Dispose cdp connection in BiDi over CDP

    @sadym-chromium
    Maksim Sadym authored and sadym-chromium committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    08132e8 View commit details
    Browse the repository at this point in the history

  4. Close BiDi browser before closing connection

    @sadym-chromium
    Maksim Sadym authored and sadym-chromium committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    38e22a7 View commit details
    Browse the repository at this point in the history

  5. Reapply "feat!: close BiDi session properly" 

    This reverts commit a7b3995db4c3f7d973be024eb6799d276944008f.
    @sadym-chromium
    Maksim Sadym authored and sadym-chromium committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    9343567 View commit details
    Browse the repository at this point in the history

  6. Update test expectations

    @sadym-chromium
    Maksim Sadym authored and sadym-chromium committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    abd7b87 View commit details
    Browse the repository at this point in the history