Add durableStorage to allowed permissions

[mushishi78]

Please tell me if I've got the wrong end of the stick, I'm totally operating under guess work. I'd like to be able to use indexeddb. I've found "durableStorage" here.

I can also see it in the dart puppeteer docs (along with a bunch of others).

So I was hoping it was as simple as just adding to this list 🤞

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[mushishi78]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[jschfflr]

@mushishi78 Thanks for your contribution! Could you add the new permission to the documentation and maybe also find a way to add a test for this? Happy to get this landed :)

[mushishi78]

@jschfflr added to docs and test. It's a bit low effort copy and paste, but possibly good enough? 🤞

[mushishi78]

@jschfflr And now rebased on main

[jschfflr]

Looks good to me, thanks!

[jschfflr]

@jschfflr added to docs and test. It's a bit low effort copy and paste, but possibly good enough? 🤞

Looks good enough to me, thanks!

[mushishi78]

Seems like the test failed on CI 😞

[jschfflr]

It looks like getPermission is using navigator.permissions.query({ name }).then((result) => result.state) internally and the durable storage thing is not exposed by that. So instead, you should probably test if access to indexeddb is granted with the permission enabled.

[jschfflr]

@mushishi78 I just tried to write a test for this usecase:

itFailsFirefox('should grant durable-storage', async () => {
      const { page, server, context } = getTestState();

      function checkIfIndexedDBIsAvailable() {
        const request = window.indexedDB.open("MyTestDatabase", 1);
        return new Promise((resolve, reject) => {
          request.onsuccess = () => resolve(true);
          request.onerror = (err) => reject(err);
        });
      }

      await context.clearPermissionOverrides();
      await page.goto(server.EMPTY_PAGE);
      expect(await page.evaluate(checkIfIndexedDBIsAvailable)).toBe(false);
      await context.overridePermissions(server.EMPTY_PAGE, ['durable-storage']);
      expect(await page.evaluate(checkIfIndexedDBIsAvailable)).toBe(true);
      await context.clearPermissionOverrides();
    });

but it looks like the durable-storage permission is not needed to create the indexedDB instance. Could you verify that this unit test actually tests the problem that you ran into?

[mushishi78]

Thanks @jschfflr. The problem for me is only when not in headless if that helps. Whenever I debug my tests I have to manually press accept on the permission.

[jschfflr]

@mushishi78 Could you share the code that you are running? Or a minimal reproduction?
I tried running HEADLESS=0 npm run unit -- -g "should grant durable-storage" but it didn't ask for permission either :/

[mushishi78]

That's frustrating. I'm going on holiday until next monday, so won't have time to until sometime next week unfortuneately. Thanks for your help.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[jschfflr]

I took a look at this change again and the underlying permissions. It looks like durableStorage maps to persistent-storage in the permission api. I therefore changed this patch to use persistent-storage instead of durable-storage. Let me know what you think!

Regarding the indexedDB test - the permission is probably only needed if the indexeddb reaches a certain since which is not the case for the test.

That's frustrating. I'm going on holiday until next monday, so won't have time to until sometime next week unfortuneately. Thanks for your help.

Have a great time off! Let me know if you're happy with the change as it is now and I'll get it merged :)

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[jschfflr]

@googlebot I consent.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[google-cla]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.