Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING - File upload doesn't work with 2.1.0 release #5363

Closed
VikramTiwari opened this issue Jan 30, 2020 · 6 comments
Closed

BREAKING - File upload doesn't work with 2.1.0 release #5363

VikramTiwari opened this issue Jan 30, 2020 · 6 comments
Labels
bug chromium Issues with Puppeteer-Chromium upstream

Comments

@VikramTiwari
Copy link
Contributor

Steps to reproduce

Tell us about your environment:

  • Puppeteer version: 2.1.0
  • Platform / OS version: any
  • URLs (if applicable): any which shows a file input dialog box
  • Node.js version: ~12

What steps will reproduce the problem?

  • Run following script
const puppeteer = require("puppeteer");

(async () => {
	const browser = await puppeteer.launch({ headless: false });
	const page = await browser.newPage();
	await page.goto("https://cgi-lib.berkeley.edu/ex/fup.html", {
		waitUntil: "networkidle2"
	});
})();

  • Click on the "choose file" button

Expectation: A file chooser dialog will appear
Result: Dialog box doesn't appear
End issue: Any upload that requires file chooser dialog breaks.
Possible reason: New changes with #5196

NOTE: It works fine with 2.0.0 release.

@gajus
Copy link

gajus commented Jan 30, 2020

Related to: #5359

@mathiasbynens
Copy link
Member

Possible reason: New changes with #5196

jsHandle.uploadFile is not used in your example, so it's not likely to be related to #5196, but rather to the upstream changes in https://chromium-review.googlesource.com/c/chromium/src/+/1935410.

@mathiasbynens
Copy link
Member

I've filed this upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1047107 Thanks for the report!

@zaki-yama
Copy link

@mathiasbynens
I have a question about the current status.
I'm facing this problem in the library that uses puppeteer.
It seems related PR (#5369 ) has already been merged, are you going to release the fixed version (v2.1.1?) soon?

@Georgegriff
Copy link

Im finding the jsHandle.uploadFile is still failing in 2.1.1 is this related or a different issue?

@gziolo
Copy link
Contributor

gziolo commented Feb 17, 2020

I wanted to integrate Puppeteer 2.1.1 but I see that fileUpload still doesn't work:
WordPress/gutenberg#20268 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug chromium Issues with Puppeteer-Chromium upstream
Projects
None yet
Development

No branches or pull requests

6 participants