chore: Fix missed src/ vs lib/ documentation
#5591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfranklin
force-pushed
the
src-lib-doc-fixes
branch
from
b376b34
to
6fa2280
Compare
jackfranklin
commented
Apr 6, 2020
| @@ -259,9 +259,8 @@ Releasing to npm consists of the following phases: | |||
| 1. On your local machine, pull from [upstream](https://github.com/puppeteer/puppeteer) and make sure the last commit is the one just merged. | |||
| 2. Run `git status` and make sure there are no untracked files. | |||
| - **WHY**: this is to avoid adding unnecessary files to the npm package. | |||
| 3. Run `npm install` to make sure the latest `lib/protocol.d.ts` is generated. | |||
There was a problem hiding this comment.
not needed now src/protocol.d.ts is git commited
mathiasbynens
approved these changes
Apr 6, 2020
mathiasbynens
approved these changes
Apr 6, 2020
Gbahdeyboh
added a commit
to Gbahdeyboh/puppeteer
that referenced
this pull request
Apr 8, 2020
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.