Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix missed src/ vs lib/ documentation #5603

Closed
wants to merge 3 commits into from
Closed

chore: Fix missed src/ vs lib/ documentation #5603

wants to merge 3 commits into from

Conversation

Gbahdeyboh
Copy link
Contributor

Fixes #5591 more

mathiasbynens
mathiasbynens approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jackfranklin

@mathiasbynens
Copy link
Member

LGTM but this seems blocked on #5595, right?

@jackfranklin
Copy link
Collaborator

These imports are deliberately left as lib/ - we need them to import from the compiled output. There should be a comment explaining that to be fair - it's non obvious. I still don't fully understand why we have these special files that just re-export from lib/ but until I do I'm keen to leave these be.

@Gbahdeyboh appreciate your help but in this case we need to leave these be unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@jackfranklin jackfranklin Awaiting requested review from jackfranklin

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gbahdeyboh @mathiasbynens @jackfranklin @googlebot