chore: migrate src/Page.js to TypeScript #5809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The final one! This is a huge file and needs to be split up and tidied, but for now I've left all the definitions in place and converted types accordingly. There's some additional tidying we can do now every `src` file is TS, but I'll leave that for another PR to avoid this one getting any bigger.
jackfranklin
commented
May 5, 2020
jackfranklin
commented
May 5, 2020
| * we can remove this and instead use the type defined in LifeCycleWatcher | ||
| */ | ||
| export type PuppeteerLifeCycleEvent = 'load' | 'domcontentloaded' | 'networkidle0' | 'networkidle2'; | ||
|
|
||
| export interface ConnectionTransport { | ||
| send(string); | ||
| close(); |
There was a problem hiding this comment.
in a follow up PR I will remove this file and find a new home for the interfaces we need where they are not exposed globally
jackfranklin
commented
May 5, 2020
jackfranklin
commented
May 5, 2020
| _viewport?: Puppeteer.Viewport; | ||
| _screenshotTaskQueue: TaskQueue; | ||
| _workers = new Map<string, PuppeteerWorker>(); | ||
| // TODO: improve this typedef - it's a function that takes a file chooser or something? |
There was a problem hiding this comment.
will do in a follow up PR
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final one! This is a huge file and needs to be split up and tidied,
but for now I've left all the definitions in place and converted types
accordingly.
There's some additional tidying we can do now every
srcfile is TS,but I'll leave that for another PR to avoid this one getting any bigger.