Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate src/Page.js to TypeScript #5809

Merged
merged 4 commits into from May 5, 2020
Merged

chore: migrate src/Page.js to TypeScript #5809

merged 4 commits into from May 5, 2020

Commits on May 5, 2020

  1. chore: migrate src/Page.js to TypeScript 

    The final one! This is a huge file and needs to be split up and tidied,
but for now I've left all the definitions in place and converted types
accordingly.

There's some additional tidying we can do now every `src` file is TS,
but I'll leave that for another PR to avoid this one getting any bigger.
    @jackfranklin
    jackfranklin committed May 5, 2020
    Copy the full SHA
    9aea53a View commit details
    Browse the repository at this point in the history

  2. tidy up @param

    @jackfranklin
    jackfranklin committed May 5, 2020
    Copy the full SHA
    a79802c View commit details
    Browse the repository at this point in the history

  3. Update utils/doclint/check_public_api/JSBuilder.js 

    Co-authored-by: Mathias Bynens <mathias@qiwi.be>
    @jackfranklin @mathiasbynens
    jackfranklin and mathiasbynens committed May 5, 2020
    Copy the full SHA
    d360753 View commit details
    Browse the repository at this point in the history

  4. fix viewport bug

    @jackfranklin
    jackfranklin committed May 5, 2020
    Copy the full SHA
    abc2d19 View commit details
    Browse the repository at this point in the history