chore: extract Request and Response into its own module
#5861
Conversation
christian-bromann
force-pushed
the
cb-splitting-up-files-request-response
branch
from
28745e6
to
f88fd0c
Compare
christian-bromann
force-pushed
the
cb-splitting-up-files-request-response
branch
from
f88fd0c
to
f7691e7
Compare
| @@ -274,8 +275,7 @@ export class NetworkManager extends EventEmitter { | |||
| const response = new Response(this._client, request, responsePayload); | |||
| request._response = response; | |||
| request._redirectChain.push(request); | |||
| response._bodyLoadedPromiseFulfill.call( | |||
| null, | |||
| response._resolveBody( | |||
There was a problem hiding this comment.
@christian-bromann is this change deliberate? Looks like we lost a call to ._bodyLoadedPromiseFulfill.
There was a problem hiding this comment.
@jackfranklin when making _bodyLoadedPromiseFulfill a private field we can't access it from NetworkManager anymore. I created a method in the Response class to allow access to it.
_resolveBody(err: Error | null): void {
return this._bodyLoadedPromiseFulfill(err);
}Alternatively I could just keep _bodyLoadedPromiseFulfill as non private field.
There was a problem hiding this comment.
Ah got you, thanks for explaining. As a general rule I think we should just do the easy privatisation work and leave any others as non private when initially splitting classes out (just to keep changes per PR down) but in this case this all looks fine to me and CI is green so no need to undo any of it 👍
Continuing with the effort of #5856 splitting classes into their own modules.