chore: move assert into its own module
#6021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of the helpers in `helpers.ts` are heavily bound to NodeJS and at the moment we're trying to make the `Connection` class be able to run in multiple environments. Its only remaining Node dependency was its reliance on `helpers.ts`, which it only needed for `assert`. This is a useful change also because `helpers.ts` is quite large and full of functions that do different things; I think we can name them better and move them into modules with a specific purpose rather than a generic `"helpers"` dumping ground. Once this change lands `Connection` should be usable in the browser.
paullewis
approved these changes
Jun 15, 2020
mathiasbynens
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the helpers in
helpers.tsare heavily bound to NodeJS and atthe moment we're trying to make the
Connectionclass be able to run inmultiple environments. Its only remaining Node dependency was its
reliance on
helpers.ts, which it only needed forassert.This is a useful change also because
helpers.tsis quite large andfull of functions that do different things; I think we can name them
better and move them into modules with a specific purpose rather than a
generic
"helpers"dumping ground.Once this change lands
Connectionshould be usable in the browser.