Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move assert into its own module #6021

Merged
merged 1 commit into from Jun 15, 2020
Merged

Commits on Jun 15, 2020

  1. chore: move assert into its own module

    A lot of the helpers in `helpers.ts` are heavily bound to NodeJS and at
    the moment we're trying to make the `Connection` class be able to run in
    multiple environments. Its only remaining Node dependency was its
    reliance on `helpers.ts`, which it only needed for `assert`.
    
    This is a useful change also because `helpers.ts` is quite large and
    full of functions that do different things; I think we can name them
    better and move them into modules with a specific purpose rather than a
    generic `"helpers"` dumping ground.
    
    Once this change lands `Connection` should be usable in the browser.
    jackfranklin committed Jun 15, 2020
    Copy the full SHA
    dc05096 View commit details
    Browse the repository at this point in the history