Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): remove emulateMedia method #6084

Merged
merged 1 commit into from Jun 23, 2020
Merged

Conversation

jackfranklin
Copy link
Collaborator

It has been deprecated for a while. In the next breaking release let's remove it.

@mathiasbynens
Copy link
Member

Let's mark this as feat(api): and make sure to include "BREAKING CHANGE" in the commit message, per https://github.com/puppeteer/puppeteer/blob/main/CONTRIBUTING.md#commit-messages.

@jackfranklin jackfranklin changed the title chore: remove emulateMedia method feat(api): remove emulateMedia method Jun 23, 2020
It has been deprecated for a while. In the next breaking release let's remove it.

BREAKING CHANGE: swap to `emulateMediaType` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants