chore: Don't store revisions in package.json
#6109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfranklin
force-pushed
the
stop-using-package-for-revisions
branch
from
2d33e91
to
4d13872
Compare
OrKoN
approved these changes
Jun 26, 2020
|
LGTM! Thanks. The next time we roll Chromium, we should update the example PR in
core also doesn't need the info in |
mathiasbynens
approved these changes
Jun 26, 2020
jackfranklin
force-pushed
the
stop-using-package-for-revisions
branch
from
4d13872
to
70c0e40
Compare
It's quite messy to have to require the `package.json` file in multiple places purely to find out what revision of a given browser we want to use. We can also achieve better type safety by placing it in an actual source file. This commit makes that change and also tidies up our reliance on `package.json` within the source code generally; we now only use it to find the location of the Puppeteer root such that we know where to install downloaded browsers to. To avoid using `package.json` to parse the name of the module, we also now explicitly have an entry point for the Puppeteer module and the Puppeter Core module. This will make it easier in the future to ship less code as part of core (e.g. core never needs to download a browser, so why ship that code?). Core can also then not have any revisions based info contained in it. The test install script has also been updated to ensure that puppeteer-core can be installed correctly too. Finally, the `install` script has been moved to TypeScript for nicer typechecking and safety. The functionality of it has not changed.
jackfranklin
force-pushed
the
stop-using-package-for-revisions
branch
from
2896b0e
to
78c313b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite messy to have to require the
package.jsonfile in multipleplaces purely to find out what revision of a given browser we want to
use. We can also achieve better type safety by placing it in an actual
source file.
This commit makes that change and also tidies up our reliance on
package.jsonwithin the source code generally; we now only use it tofind the location of the Puppeteer root such that we know where to
install downloaded browsers to.
To avoid using
package.jsonto parse the name of the module, we alsonow explicitly have an entry point for the Puppeteer module and the
Puppeter Core module. This will make it easier in the future to ship
less code as part of core (e.g. core never needs to download a browser,
so why ship that code?).
The test install script has also been updated to ensure that
puppeteer-core can be installed correctly too.