Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Don't store revisions in package.json #6109

Merged
merged 5 commits into from Jun 29, 2020
Merged

chore: Don't store revisions in package.json #6109

merged 5 commits into from Jun 29, 2020

Commits on Jun 29, 2020

  1. chore: Don't store revisions in package.json 

    It's quite messy to have to require the `package.json` file in multiple
places purely to find out what revision of a given browser we want to
use. We can also achieve better type safety by placing it in an actual
source file.

This commit makes that change and also tidies up our reliance on
`package.json` within the source code generally; we now only use it to
find the location of the Puppeteer root such that we know where to
install downloaded browsers to.

To avoid using `package.json` to parse the name of the module, we also
now explicitly have an entry point for the Puppeteer module and the
Puppeter Core module. This will make it easier in the future to ship
less code as part of core (e.g. core never needs to download a browser,
so why ship that code?). Core can also then not have any revisions based
info contained in it.

The test install script has also been updated to ensure that
puppeteer-core can be installed correctly too.

Finally, the `install` script has been moved to TypeScript for nicer
typechecking and safety. The functionality of it has not changed.
    @jackfranklin
    jackfranklin committed Jun 29, 2020
    Copy the full SHA
    78c313b View commit details
    Browse the repository at this point in the history

  2. Fix location of puppeteer core build

    @jackfranklin
    jackfranklin committed Jun 29, 2020
    Copy the full SHA
    f45d94c View commit details
    Browse the repository at this point in the history

  3. Ignore any local tarballs from test script

    @jackfranklin
    jackfranklin committed Jun 29, 2020
    Copy the full SHA
    e7f1a69 View commit details
    Browse the repository at this point in the history

  4. Remove bad git reset

    @jackfranklin
    jackfranklin committed Jun 29, 2020
    Copy the full SHA
    5c84bcf View commit details
    Browse the repository at this point in the history

  5. travis change

    @jackfranklin
    jackfranklin committed Jun 29, 2020
    Copy the full SHA
    59c398c View commit details
    Browse the repository at this point in the history