fix: Inherit browser-level proxy settings from incognito context

[jimmydief]

What kind of change does this PR introduce?

This fixes #7589 which was a regression caused by #7516 and released in 10.4.0. It closes #7677 which fixed part of the issue but did not cover the proxy bypass list and also did not include tests.

Did you add tests for your changes?

Yes.

If relevant, did you update the documentation?

N/A

Summary

Browser-level proxy settings are now once again respected when creating new incognito browser contexts. Browser-level settings can be overridden at the context level. Tests were added for request proxy behavior in general.

Does this PR introduce a breaking change?

Nope.

Other information

N/A

[jimmydief]

Omitting the defaults here causes the browser-level settings to be respected if these aren't provided.

[jimmydief]

Creating a simple proxy server which forwards requests on to the TestServer.

[iJoris]

You are missing the cla
https://github.com/puppeteer/puppeteer/blob/7c0a7b92cf98033425b78e1e7a96bb440a636123/CONTRIBUTING.md#contributor-license-agreement

[jimmydief]

You are missing the cla https://github.com/puppeteer/puppeteer/blob/7c0a7b92cf98033425b78e1e7a96bb440a636123/CONTRIBUTING.md#contributor-license-agreement

Signed it after opening the PR, seems like updating the status check might require some manual step.

[Momotoculteur]

Hello guys :)

Any news from this PR ? I need it for my project, i cannot upgrade anymore then my pptr version.

Thank in advance,
Bastien

[Niek]

Ping @OrKoN @nschonni

[OrKoN]

I think the new tests will be failing in Firefox as expected. Could you please add itFailsFirefox instead of it for those tests?

[jimmydief]

@OrKoN The test failure on Windows actually seems to be pointing out the issue reported in #7873, #7719, and #7698. I put it behind itFailsWindows for now and left a comment referring to those issues.

[iJoris]

@jimmydief, closed that issue already.

If you need testing on windows, hit me up.

[jimmydief]

@jimmydief, closed that issue already.

If you need testing on windows, hit me up.

@iJoris Gotcha, thanks. The only test that was failing was related to createIncognitoBrowserContext with the proxyServer argument provided. Could you confirm whether the example from #7698 fails on your Windows machine?

[iJoris]

@jimmydief, closed that issue already.
If you need testing on windows, hit me up.

@iJoris Gotcha, thanks. The only test that was failing was related to createIncognitoBrowserContext with the proxyServer argument provided. Could you confirm whether the example from #7698 fails on your Windows machine?
Hi,

I can confirm that the proxy server and an createIncognitoBrowserContext do not work after 10.2. Seems that the proxyServer gets ignored in an incognitoBrowserContext.

I thought that this PR would resolve this issue tho? Otherwise, I create my own issue.
#7873 is the same problem.

#7589 (comment)