fix: ensure incognito sessions obey proxy server settings (#7589) #7677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to resolve issue #7589 - i.e. it's a bug fix because as of 10.4.0 Puppeteer will ignore proxy settings when using incognito sessions.
No tests added. It would be good to have a test that would spot this kind of regression, but it is beyond my abilities to create such a test. (I am not really much of a JavaScript programmer). Issue #7589 includes an example that fails under 10.4.0, ...TBC...
Summary
This PR attempts to repair an accidental breaking change introduced in 10.4.0.