fix: typo in InterceptResolutionStrategy #7780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @harshagrawal523! I noticed the same typo and was going to open a PR when I saw this one 😄 Can you sign the CLA and fix the commit message to follow the Conventional Commits standard so the tests can run? (e.g. |
|
Hi , actually this was my first PR , I just signed my CLA , what should I do next? |
harshagrawal523
changed the title
|
@harshagrawal523 I think a maintainer has to approve the workflow, since it's your first PR. Let's wait and see 👀 Update: This typo has been also fixed in #7796. |
benallfree
suggested changes
Nov 28, 2021
| @@ -216,7 +216,7 @@ export class HTTPRequest { | |||
| */ | |||
| private interceptResolution(): [InterceptResolutionStrategy, number?] { | |||
| if (!this._allowInterception) return ['disabled']; | |||
| if (this._interceptionHandled) return ['alreay-handled']; | |||
| if (this._interceptionHandled) return ['already-handled']; | |||
There was a problem hiding this comment.
The InterceptResolutionStrategy must be updated too.
There was a problem hiding this comment.
ohh , I will check it once
This was referenced Nov 29, 2021
|
Fixed in #7813 |
OrKoN
pushed a commit
that referenced
this pull request
Dec 9, 2021
This was referenced Jan 25, 2023
This was referenced Feb 4, 2023
This was referenced Jul 4, 2023
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
There was a typo in line 210.
Did you add tests for your changes?
No
Summary
Does this PR introduce a breaking change?
No
Other information
None