Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement Element.waitForSelector #7825

Merged
merged 3 commits into from Dec 9, 2021
Merged

feat: implement Element.waitForSelector #7825

merged 3 commits into from Dec 9, 2021

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Dec 7, 2021

Issues: #6427

@OrKoN OrKoN requested a review from johanbay December 7, 2021 11:17
@OrKoN OrKoN force-pushed the element-waitForSelector branch 2 times, most recently from 7a77b85 to beacff1 Compare December 7, 2021 11:37
johanbay
johanbay approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@johanbay johanbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

src/common/JSHandle.ts Outdated Show resolved Hide resolved
src/common/JSHandle.ts Outdated Show resolved Hide resolved
src/common/JSHandle.ts Outdated Show resolved Hide resolved
src/common/JSHandle.ts Outdated Show resolved Hide resolved
@OrKoN @johanbay
feat: implement Element.waitForSelector
f30ca29 
Co-authored-by: Johan Bay <jobay@google.com>
@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 9, 2021

@mathiasbynens pls take a look!

mathiasbynens
mathiasbynens approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % some suggestions to make the docs precise

docs/api.md Outdated Show resolved Hide resolved
@OrKoN @mathiasbynens
fix: update docs/api.md
a3d2300 
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
@OrKoN OrKoN enabled auto-merge (squash) December 9, 2021 11:37
@OrKoN OrKoN merged commit c034294 into main Dec 9, 2021
@OrKoN OrKoN deleted the element-waitForSelector branch December 9, 2021 11:51
@campersau campersau mentioned this pull request Dec 14, 2021
Closed
@YusukeIwaki YusukeIwaki mentioned this pull request Jan 1, 2022
Merged
This was referenced May 30, 2022
Closed
Closed
This was referenced May 30, 2022
Closed
Closed
Closed
This was referenced May 30, 2022
Closed
Closed
This was referenced Jun 13, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@johanbay johanbay johanbay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OrKoN @mathiasbynens @johanbay