fix: Kill browser process when 'taskkill' fails on Windows #8352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
May 16, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 6, 2022
Closed
jimmydief
added a commit
to jimmydief/puppeteer
that referenced
this pull request
Jun 6, 2022
Fixes puppeteer#8476. Similar fix to puppeteer#8352 which only covered Windows.
jimmydief
added a commit
to jimmydief/puppeteer
that referenced
this pull request
Jun 6, 2022
Fixes puppeteer#8476. Similar fix to puppeteer#8352 which only covered Windows.
jrandolf
pushed a commit
to jimmydief/puppeteer
that referenced
this pull request
Jun 7, 2022
Fixes puppeteer#8476. Similar fix to puppeteer#8352 which only covered Windows.
jrandolf
pushed a commit
that referenced
this pull request
Jun 7, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No, this PR affects windows only and affects how we shut down the browser process.
Summary
On windows, we use
taskkillto kill the browser process. The reason is that we want to shutdown the whole process group, i.e. also kill all child processes spawned by the browser process. Callingtaskkillcan fail though, if its called by a user with not enough privileges, in that case we should fall back to usingsubprocess.kill.As per Node.js documentation we also cleanup all the processes of a process group as long as we do not start the browser process in detached mode (which we do not do) once the main Node.js process dies.
Does this PR introduce a breaking change?
No
Other information
This might also fix issue #7922.