Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 13.4.0 regression caused by permission issues when killing browser process group #8476

Closed
jimmydief opened this issue Jun 6, 2022 · 0 comments · Fixed by #8477
Closed
Labels

Comments

@jimmydief
Copy link
Contributor

Bug description

Steps to reproduce the problem:

I'm having trouble creating a simplified reproduction of this, including one which uses my same Jest setup. My scenario is the following:

  1. In (Jest) unit tests for a Node.js server which uses Puppeteer, I launch a new server + corresponding Puppeteer instance in each test case and tear down the server/browser at the end of each test.
  2. After upgrading to Puppeteer 13.4.0, test teardown fails with:

Puppeteer was unable to kill the process which ran the browser binary.
This means that, on future Puppeteer launches, Puppeteer might not be able to launch the browser.
Please check your open processes and ensure that the browser processes that Puppeteer launched have been killed.
If you think this is a bug, please report it on the Puppeteer issue tracker.
Error cause: Error: kill EPERM

This appears to be a regression from #6859. A similar fix to #8352 for MacOS/Linux seems like it may be necessary in some scenarios.

Puppeteer version

13.4.0

Node.js version

14.16.1

npm version

6.14.12

What operating system are you seeing the problem on?

macOS

Relevant log output

No response

@jimmydief jimmydief added the bug label Jun 6, 2022
jimmydief added a commit to jimmydief/puppeteer that referenced this issue Jun 6, 2022
jimmydief added a commit to jimmydief/puppeteer that referenced this issue Jun 6, 2022
jrandolf pushed a commit to jimmydief/puppeteer that referenced this issue Jun 7, 2022
jrandolf pushed a commit that referenced this issue Jun 7, 2022
Fixes #8476. Similar fix to #8352 which only covered Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant