You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similar to #8476, I can only reproduce this when killing Puppeteer as part of the teardown logic of my Jest tests. The stack trace looks like this:
kill ESRCH
at pidExists (node_modules/puppeteer/src/node/BrowserRunner.ts:331:20)
at BrowserRunner.kill (node_modules/puppeteer/src/node/BrowserRunner.ts:190:39)
at node_modules/puppeteer/src/node/BrowserRunner.ts:177:14
I believe that this is likely only reproducible in Jest due to jestjs/jest#2549. Regardless, the instanceof Error check here seems unnecessary. Given that Puppeteer is likely widely used in Jest, fixing this here seems practical.
puppeteer#8497 does not seem to have been fully resolved for me with 14.4.0 (puppeteer#8504), likely because the `instanceof` check being changed in this PR also causes issues in Jest due to jestjs/jest#2549. I was able to confirm that this change avoids the error I've been seeing in CI by testing this change via `patch-package`.
Bug description
Similar to #8476, I can only reproduce this when killing Puppeteer as part of the teardown logic of my Jest tests. The stack trace looks like this:
I believe that this is likely only reproducible in Jest due to jestjs/jest#2549. Regardless, the
instanceof Error
check here seems unnecessary. Given that Puppeteer is likely widely used in Jest, fixing this here seems practical.puppeteer/src/node/BrowserRunner.ts
Line 333 in 465a7c4
Puppeteer version
13.4.0
Node.js version
14.16.1
npm version
6.14.12
What operating system are you seeing the problem on?
macOS
Relevant log output
No response
The text was updated successfully, but these errors were encountered: