fix: remove instanceof Error check causing issues in Jest
#8498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmydief
commented
Jun 9, 2022
| @@ -330,12 +330,10 @@ function pidExists(pid: number): boolean { | |||
| try { | |||
| return process.kill(pid, 0); | |||
| } catch (error) { | |||
| if (error instanceof Error) { | |||
There was a problem hiding this comment.
I believe that the instanceof Error check here is failing when running Puppeteer in Jest due to jestjs/jest#2549. This seems to be timing-dependent in my tests and I've had a hard time reproducing it outside of CI.
Given that process.kill(...) is part of the standard library, checking that it throws Errors seems unnecessary anyways.
|
Closed in favor of #8504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
Did you add tests for your changes?
No.
If relevant, did you update the documentation?
N/A
Summary
Fixes #8497.
Does this PR introduce a breaking change?
No
Other information