Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TS2304 compilation errors #8986

Closed
akornatskyy opened this issue Sep 19, 2022 · 4 comments · Fixed by #8987
Closed

[Bug]: TS2304 compilation errors #8986

akornatskyy opened this issue Sep 19, 2022 · 4 comments · Fixed by #8987
Assignees
Labels

Comments

@akornatskyy
Copy link

Bug description

Steps to reproduce the problem:

  1. upgrade to 18.0.1
  2. compile

Puppeteer version

18.0.1

Node.js version

18.9.0

npm version

8.19.1

What operating system are you seeing the problem on?

Linux

Relevant log output

.../puppeteer-core/lib/types.d.ts(2879,48): error TS2304: Cannot find name 'Poller_2'.
.../puppeteer-core/lib/types.d.ts(5697,13): error TS2552: Cannot find name 'Poller_2'. Did you mean 'Poller'?
.../puppeteer-core/lib/types.d.ts(5698,13): error TS2304: Cannot find name 'MutationPoller'.
.../puppeteer-core/lib/types.d.ts(6012,39): error TS2304: Cannot find name 'createDeferredPromise'.
.../puppeteer-core/lib/types.d.ts(6032,43): error TS2304: Cannot find name 'Poller_2'.
.../puppeteer-core/lib/types.d.ts(6367,18): error TS2304: Cannot find name 'isSuitableNodeForTextMatching'.
.../puppeteer-core/lib/types.d.ts(6368,18): error TS2304: Cannot find name 'TextContent_2'.
.../puppeteer-core/lib/types.d.ts(6368,18): error TS2552: Cannot find name 'TextContent_2'. Did you mean 'TextContent'?
.../puppeteer-core/lib/types.d.ts(6369,18): error TS2304: Cannot find name 'createTextContent'.
@stevenwdv
Copy link

stevenwdv commented Sep 19, 2022

Still happens in 18.0.2, also happens in 18.0.0

@OrKoN
Copy link
Collaborator

OrKoN commented Sep 19, 2022

@stevenwdv I am unable to reproduce with 18.0.2. Are you sure it happens with 18.0.2?

@OrKoN
Copy link
Collaborator

OrKoN commented Sep 19, 2022

I was not able to repro the issue with 18.0.2 but I saw that we still have mentions of some internal utils in types.d.ts. Opened #8987

@akornatskyy
Copy link
Author

the issue is similar with 18.0.2:

.../puppeteer-core/lib/types.d.ts(5691,13): error TS2552: Cannot find name 'Poller_2'. Did you mean 'Poller'?
.../puppeteer-core/lib/types.d.ts(5692,13): error TS2304: Cannot find name 'MutationPoller'.
.../puppeteer-core/lib/types.d.ts(5693,13): error TS2304: Cannot find name 'RAFPoller'.
.../puppeteer-core/lib/types.d.ts(5693,13): error TS2552: Cannot find name 'RAFPoller'. Did you mean 'Poller'?
.../puppeteer-core/lib/types.d.ts(5694,13): error TS2304: Cannot find name 'IntervalPoller'.
.../puppeteer-core/lib/types.d.ts(6006,39): error TS2304: Cannot find name 'createDeferredPromise'.
.../puppeteer-core/lib/types.d.ts(6355,18): error TS2304: Cannot find name 'isSuitableNodeForTextMatching'.
.../puppeteer-core/lib/types.d.ts(6356,18): error TS2304: Cannot find name 'TextContent_2'.
.../puppeteer-core/lib/types.d.ts(6356,18): error TS2552: Cannot find name 'TextContent_2'. Did you mean 'TextContent'?
.../puppeteer-core/lib/types.d.ts(6357,18): error TS2304: Cannot find name 'createTextContent'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants