fix: change injected.ts imports #8987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why api-extractor generates broken .d.ts files if the start import is used for Poller and TextContext.
OrKoN
force-pushed
the
fix-internal-puppeteer-utils
branch
from
fec6f09
to
6513bfc
Compare
OrKoN
changed the title
I guess Poller.ts and TextContext.ts also export |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it looks like local type aliases have to be marked as
@internaltoo or they leak into types.d.ts. Also, not sure why api-extractor generates broken .d.ts files if the star import is used for Poller and TextContext.Drive-by: updated tsd tests to use the generated types.d.ts instead of only using esm/types.d.ts
Closes #8986