test: do not check for secure field in test for delete cookies #12074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning00Blade
force-pushed
the
do-not-check-secure-field
branch
from
cc1832d
to
d6ce416
Compare
OrKoN
force-pushed
the
do-not-check-secure-field
branch
from
d6ce416
to
4335af1
Compare
OrKoN
force-pushed
the
main
branch
4 times, most recently
from
2ff1e4f
to
e0932e5
Compare
sadym-chromium
approved these changes
Apr 16, 2024
Lightning00Blade
force-pushed
the
do-not-check-secure-field
branch
from
4335af1
to
706d069
Compare
lutien
force-pushed
the
do-not-check-secure-field
branch
3 times, most recently
from
861f5cc
to
2913e10
Compare
lutien
force-pushed
the
do-not-check-secure-field
branch
from
2913e10
to
ab911b5
Compare
|
@Lightning00Blade or @OrKoN, CI checks are green, could you merge this PR? 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the changes in #12039, checking for
securefield beingtruewill not be compatible with Firefox.Note: the test will not pass yet for Firefox. Update: It passes now.