refactor!: merge Puppeteer and PuppeteerNode #12291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/refactor-puppeteer-node
branch
2 times, most recently
from
cf9d1fc
to
1bb06d7
Compare
Lightning00Blade
approved these changes
Apr 18, 2024
OrKoN
changed the title
OrKoN
force-pushed
the
orkon/refactor-puppeteer-node
branch
3 times, most recently
from
857fa43
to
45562d8
Compare
OrKoN
force-pushed
the
orkon/refactor-puppeteer-node
branch
from
45562d8
to
9602765
Compare
|
closing in favour of #12350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PuppeeteerNode was a main class with Puppeteer being a base class. Both puppeteer and puppeteer-core exposed PuppeteerNode.
TODO: we need a code path which uses Puppeteer but skips all node depdencies.