feat(worker): Allow Workers to emit their network events

[chad3814]

small patch that hooks Workers into the NetworkManager so that they can emit network events

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[chad3814]

I signed it!

[googlebot]

CLAs look good, thanks!

[JoelEinbinder]

Thanks for the PR!

Maybe we should have these events fired on the page, like we do for frames. Wdyt @aslushnikov ?

Also needs a test.

[chad3814]

yeah I was sure how to make some tests, I'm not familiar with how the coverage tests work, there don't appear to be specific tests for the Page versions, they just look like they get exercised in the process of other tests. Something similar could be done in Worker but where do those tests get their worker script? I can change it to open another remote resource.

[chad3814]

Okay wrote tests :)

[chad3814]

The travis build had a timeout on a different test I didn't touch and AppVeyor succeeded on that test...

[aslushnikov]

@chad3814 we played with this and found critical issues with nested targets in DevTools protocol:

• events are not fired when request interception is enabled in the main target
• network throttling doesn't quite work with subtargets

We'll have to fix these in Chromium as a part of #2548. There's no ETA for OOPIFs since it's unclear what else is broken in puppeteer with multiple subtargets.

I'll close this PR for now since there's no way we can move forward here without upstream being fixed.
I filed #2781 to track the feature.

Thank you for the PR!