New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(request): add request.initiator() method. #4578
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
03a4ca1
to
d4b17bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me!
@atersolis Could you make sure to sign the CLA and let the @googlebot know? Happy to land your change then :) |
add request.initiator() method, with tests and api doc Requested by puppeteer#1395
As there hasn't been an update on this change for a while, closing this in favor of #7614 |
add request.initiator() method, with tests and api doc
Requested by #1395
I was looking for this feature, and after reading the code, I realised it was really easy to implement.
All it took was 8 lines (+doc and tests). I wonder why it was not added earlier ?