Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(request): add request.initiator() method. #4578

Closed
wants to merge 1 commit into from

Conversation

atersolis
Copy link
Contributor

add request.initiator() method, with tests and api doc

Requested by #1395

I was looking for this feature, and after reading the code, I realised it was really easy to implement.
All it took was 8 lines (+doc and tests). I wonder why it was not added earlier ?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@atersolis
Copy link
Contributor Author

atersolis commented Jun 12, 2019

Oh my bad, I read the issue too fast, I didn't see #1817
Well, there were no tests, so I guess it's not completely useless
It's been more than a year since #1817 though, so what's going on ?

Copy link
Contributor

@jschfflr jschfflr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me!

@google-cla google-cla bot added the cla: no label Sep 11, 2021
@jschfflr
Copy link
Contributor

@atersolis Could you make sure to sign the CLA and let the @googlebot know? Happy to land your change then :)

add request.initiator() method, with tests and api doc

Requested by puppeteer#1395
@jschfflr
Copy link
Contributor

As there hasn't been an update on this change for a while, closing this in favor of #7614

@jschfflr jschfflr closed this Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants