Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chromium): roll Chromium to r682225 #4844

Merged
merged 1 commit into from Aug 14, 2019
Merged

feat(chromium): roll Chromium to r682225 #4844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/Launcher.js
View file
Open in desktop
Expand Up @@ -46,9 +46,8 @@ const DEFAULT_ARGS = [
'--disable-default-apps',
'--disable-dev-shm-usage',
'--disable-extensions',
// TODO: Support OOOPIF. @see https://github.com/GoogleChrome/puppeteer/issues/2548
// BlinkGenPropertyTrees disabled due to crbug.com/937609
'--disable-features=site-per-process,TranslateUI,BlinkGenPropertyTrees',
'--disable-features=TranslateUI,BlinkGenPropertyTrees',
'--disable-hang-monitor',
'--disable-ipc-flooding-protection',
'--disable-popup-blocking',
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@
"node": ">=6.4.0"
},
"puppeteer": {
"chromium_revision": "681777"
"chromium_revision": "682225"
},
"scripts": {
"unit": "node test/test.js",
Expand Down
12 changes: 11 additions & 1 deletion test/headful.spec.js
View file
Open in desktop
Expand Up @@ -86,7 +86,8 @@ module.exports.addTests = function({testRunner, expect, puppeteer, defaultBrowse
await rmAsync(userDataDir).catch(e => {});
expect(cookie).toBe('foo=true');
});
it('OOPIF: should report google.com frame', async({server}) => {
// TODO: Support OOOPIF. @see https://github.com/GoogleChrome/puppeteer/issues/2548
xit('OOPIF: should report google.com frame', async({server}) => {
// https://google.com is isolated by default in Chromium embedder.
const browser = await puppeteer.launch(headfulOptions);
const page = await browser.newPage();
Expand Down Expand Up @@ -116,6 +117,15 @@ module.exports.addTests = function({testRunner, expect, puppeteer, defaultBrowse
await page.click('body');
await browser.close();
});
it('should open devtools when "devtools: true" option is given', async({server}) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firefox won't like this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? We run headful tests on CHROME only

const browser = await puppeteer.launch({...headfulOptions, devtools: true});
const context = await browser.createIncognitoBrowserContext();
await Promise.all([
context.newPage(),
context.waitForTarget(target => target.url().startsWith('devtools://')),
]);
await browser.close();
});
});

describe('Page.bringToFront', function() {
Expand Down