New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api.md): use async/await instead of then #5089
docs(api.md): use async/await instead of then #5089
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
docs/api.md
Outdated
resolve(text); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now no longer matches the current Puppeteer coding style.
docs/api.md
Outdated
const page = await browser.newPage(); | ||
await page.goto('https://www.google.com/chrome/browser/canary.html'); | ||
dumpFrameTree(page.mainFrame(), ''); | ||
await browser.close(); | ||
|
||
function dumpFrameTree(frame, indent) { | ||
console.log(indent + frame.url()); | ||
for (let child of frame.childFrames()) | ||
for (let child of frame.childFrames()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for (let child of frame.childFrames()) { | |
for (const child of frame.childFrames()) { |
e441103
to
5c9813c
Compare
Thanks! |
fixes #5082