New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow overwrite the path for the downloads folder #5105
Conversation
e.g.: ```bash PUPPETEER_DOWNLOAD_PATH=/store/chromiums npm install ```
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I'm guessing this PR is dead in the water?
Independently of this PR turns out, great work |
03a4ca1
to
d4b17bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fengmk2 Thanks for your contribution! Could you verify it's still relevant and update it to resolve the merge conflicts? Happy to get this landed :)
This functionality has already landed in #6014. But thanks for your contribution anyways! |
@jschfflr :) |
e.g.: