style(page): Refactored code to remove redundancy #5121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were multiple if block in the logic that can be ironed out into a single statement, which is much more robust and readable.
yashLadha
force-pushed
the
master
branch
2 times, most recently
from
c24bfb3
to
acc5825
Compare
|
There is some flakiness around |
|
@aslushnikov Can you please review the PR? |
… tests This patch includes the changes from puppeteer#5116
| @@ -42,6 +42,7 @@ module.exports.addTests = function({testRunner, expect, FFOX}) { | |||
| </select> | |||
| </body>`); | |||
|
|
|||
| await page.focus('[placeholder="Empty input"]'); | |||
There was a problem hiding this comment.
Please remove these unrelated changes from this patch
| else if (mimeType === 'image/jpeg') | ||
| screenshotType = 'jpeg'; | ||
| const mimeMatch = mimeType.match(/^image\/(png|jpeg)$/); | ||
| screenshotType = Array.isArray(mimeMatch) ? mimeMatch[1] || null : null; |
There was a problem hiding this comment.
This is less readable than the original code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple if block in the logic that can be ironed
out into a single statement, which is much more robust and readable.