Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launcher): Provide option to run puppeteer with different browsers #5137

Merged
merged 6 commits into from Nov 26, 2019

Commits on Nov 9, 2019

  1. feat: Set which browser to launch via PUPPETEER_PRODUCT

    This change introduces a PUPPETEER_PRODUCT environment
    variable as a first step toward using Puppeteer with
    many different browsers. Setting PUPPETEER_PRODUCT=firefox, for
    example, enables Firefox-specific Launcher settings.
    
    The state is also exposed as `puppeteer.product` in the API
    to support adding other product-specific behaviour as needed.
    
    The bulk of the change is a refactoring in Launcher
    to decouple generic browser start-up from product-specific
    configuration.
    mjzffr committed Nov 9, 2019
    Copy the full SHA
    87f3714 View commit details
    Browse the repository at this point in the history
  2. test: Distinguish Juggler unit tests from Firefox

    The funit script is renamed to fjunit (j for Juggler, which is
    used only by the experimental puppeteer-firefox package.
    
    In contrast, the funit script now refers to running Puppeteer
    unit tests against the main puppeteer package with Firefox.
    To do so with Firefox Nightly, run:
    
    `BINARY=path/to/firefox npm run funit`
    
    A number of changes in this patch make it easier to run
    Puppeteer unit tests in Mozilla's CI.
    mjzffr committed Nov 9, 2019
    Copy the full SHA
    53de1a3 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    16d36fb View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. (lib) fixups

    mjzffr committed Nov 15, 2019
    Copy the full SHA
    9fa12a7 View commit details
    Browse the repository at this point in the history
  2. (test) fixups

    mjzffr committed Nov 15, 2019
    Copy the full SHA
    419cd76 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. (fixup) Enable setting a product programmatically

    Respecting the puppeteer-core restriction for PUPPETEER_
    environment variables, lazily instantiate the Launcher
    based on a `product` Puppeteer.launch option, if available.
    mjzffr committed Nov 25, 2019
    Copy the full SHA
    7cc6163 View commit details
    Browse the repository at this point in the history