Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frame): Fix Frame.waitFor's XPath pattern detection #5184

Merged
merged 6 commits into from Sep 15, 2021
Merged

fix(frame): Fix Frame.waitFor's XPath pattern detection #5184

merged 6 commits into from Sep 15, 2021

Commits on Nov 21, 2019

  1. fix(frame): Fix Frame.waitFor's XPath pattern detection 

        Up to now, only strings starting with '//' are considered as to XPath selectors. Unfortunately, this is too restricting. This fix allows valid XPath selectors starting with: '/', './', and even '(//*[1])'
    @xprudhomme
    xprudhomme committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    2688cb0 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. fix(frame): Change Frame's waitFor xPathPattern 

    This patch allows to wait for and select an element with a parenthesis-starting xpath. Before this, only double slashes starting xpath were allowed.
    @xprudhomme
    xprudhomme committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    3fd2b5e View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Merge remote-tracking branch 'origin/main' into fix/FrameWaitForXPath… 

    …Pattern
    @jschfflr
    jschfflr committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    3c6da47 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/FrameWaitForXPathPattern

    @jschfflr
    jschfflr committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    3944c78 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Merge branch 'main' into fix/FrameWaitForXPathPattern

    @jschfflr
    jschfflr committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    ee74d8d View commit details
    Browse the repository at this point in the history

  2. chore: eslint-fix

    @jschfflr
    jschfflr committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    5006ca8 View commit details
    Browse the repository at this point in the history