Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prepare jsHandle.uploadFile for CDP Page.handleFileChooser removal #5196

Merged
merged 2 commits into from Dec 3, 2019
Merged

fix: prepare jsHandle.uploadFile for CDP Page.handleFileChooser removal #5196

merged 2 commits into from Dec 3, 2019

Commits on Nov 26, 2019

  1. fix: prepare jsHandle.uploadFile for CDP Page.handleFileChooser removal 

    https://chromium-review.googlesource.com/c/chromium/src/+/1935410
removes Page.handleFileChooser from the CDP.
    @mathiasbynens
    mathiasbynens committed Nov 26, 2019
    Copy the full SHA
    fa71566 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. fix: improve binary file support 

    UTF-8-decoding the input file could fail for binary files, and so we
now read the raw file buffer and base64-encode it. To base64-decode it
within the page context, we use the Fetch API in combination with a
data URL. This requires knowing the proper MIME type for the input
file, which we now figure out using the new mime-types dependency.
    @mathiasbynens
    mathiasbynens committed Nov 27, 2019
    Copy the full SHA
    e7dcfeb View commit details
    Browse the repository at this point in the history