Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require https-proxy-agent only when actually needed #5224

Closed
wants to merge 1 commit into from
Closed

Require https-proxy-agent only when actually needed #5224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/BrowserFetcher.js
View file
Open in desktop
Expand Up @@ -23,8 +23,6 @@ const URL = require('url');
const {helper, assert} = require('./helper');
const removeRecursive = require('rimraf');
// @ts-ignore
const ProxyAgent = require('https-proxy-agent');
// @ts-ignore
const getProxyForUrl = require('proxy-from-env').getProxyForUrl;

const DEFAULT_DOWNLOAD_HOST = 'https://storage.googleapis.com';
Expand Down Expand Up @@ -285,6 +283,8 @@ function httpRequest(url, method, response) {
const parsedProxyURL = URL.parse(proxyURL);
parsedProxyURL.secureProxy = parsedProxyURL.protocol === 'https:';

// @ts-ignore
const ProxyAgent = require('https-proxy-agent');
options.agent = new ProxyAgent(parsedProxyURL);
options.rejectUnauthorized = false;
}
Expand Down