Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add mimeType to the File instance uploadFile() #5358

Closed
wants to merge 2 commits into from
Closed

Fix: Add mimeType to the File instance uploadFile() #5358

wants to merge 2 commits into from

Conversation

heikkipora
Copy link

@heikkipora heikkipora commented Jan 29, 2020

Not having the File.type property present breaks fileUpload functionality for implementations that rely on the file mime type being set by the browser.

Was broken in release 2.1.0 by commit 6091a34

Not having the File.type property present breaks fileUpload functionality for implementations that rely on the file mime type being set by the browser
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mathiasbynens
Copy link
Member

Could you please add a test that fails without this patch but succeeds with it? Thanks.

@heikkipora
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@heikkipora
Copy link
Author

heikkipora commented Jan 29, 2020

Updated input.spec.js to cover the new type property and linked the breaking commit to PR description

@reedom
Copy link

reedom commented Mar 26, 2020

Hi, this patch is what I was about to write by myself to solve an issue on my project.
It looks got paused over a month.
Who's responsible to proceed it?
And/or is there anything I can do for that?

@renfeng
Copy link

renfeng commented Apr 1, 2020

@mathiasbynens Could you help the people out?

@mathiasbynens
Copy link
Member

@paullewis, could you PTAL in light of #5654?

@paullewis
Copy link
Contributor

This is fixed as of 532ae57

@paullewis paullewis closed this Apr 16, 2020
@SimonSchick
Copy link

SimonSchick commented Apr 17, 2020

Are you sure this is fixed?
I'm having an issue where when calling uploadFile seems to add files to the upload with no mime type.

image

This does not occur when using the browser manually.

@paullewis
Copy link
Contributor

Hi Simon, which version is this? The fix isn't in a release version yet, so to check you'd need to npm install https://github.com/puppeteer/puppeteer to get what's on master.

@SimonSchick
Copy link

That's probably why, I assumed the fix was in yesterdays 3.0.0 release 🙂
It's always confusing when an issue is marked as closed but the fix isn't technically released yet 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants