New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add mimeType to the File instance uploadFile() #5358
Conversation
Not having the File.type property present breaks fileUpload functionality for implementations that rely on the file mime type being set by the browser
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Could you please add a test that fails without this patch but succeeds with it? Thanks. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Updated input.spec.js to cover the new type property and linked the breaking commit to PR description |
Hi, this patch is what I was about to write by myself to solve an issue on my project. |
@mathiasbynens Could you help the people out? |
@paullewis, could you PTAL in light of #5654? |
This is fixed as of 532ae57 |
Hi Simon, which version is this? The fix isn't in a release version yet, so to check you'd need to |
That's probably why, I assumed the fix was in yesterdays 3.0.0 release 🙂 |
Not having the File.type property present breaks fileUpload functionality for implementations that rely on the file mime type being set by the browser.
Was broken in release 2.1.0 by commit 6091a34